lkml.org 
[lkml]   [2008]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [mmotm and linux-next][PATCH] irq: enclose irq_desc_lock_class in CONFIG_LOCKDEP

* Ingo Molnar <mingo@elte.hu> wrote:

> > > #include "internals.h"
> > >
> > > +#ifdef CONFIG_LOCKDEP
> > > /*
> > > * lockdep: we want to handle all irq_desc locks as a single lock-class:
> > > */
> > > static struct lock_class_key irq_desc_lock_class;
> > > +#endif
> > >
> > > /**
> > > * handle_bad_irq - handle spurious and unhandled irqs
> > >
> >
> > No, lockdep.h (which we forgot to include) already handles that:
> >
> > # define lockdep_set_class(lock, key) do { (void)(key); } while (0)
> >
> > the problem is that the code which references irq_desc_lock_class is
> > inside #ifdef CONFIG_SPARSE_IRQ, so this is a better fix:
>
> agreed that this is the better fix - applied to tip/irq/sparseirq,
> thanks!

actually, this breaks the build on !SPARSEIRQ because we will use that
class in the non-sparseirq case. So we've converted a build warning to a
build failure ;-)

Ingo


\
 
 \ /
  Last update: 2008-12-16 11:27    [W:0.056 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site