lkml.org 
[lkml]   [2008]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 1/9] ide: update ide_unregister() documentation
    From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Subject: [PATCH] ide: update ide_unregister() documentation

    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    ---
    just a couple of cleanups, should be applied on a top of Sunday's patchset
    [ http://marc.info/?l=linux-kernel&m=122921159918716&w=2 ]

    drivers/ide/ide.c | 18 +++++-------------
    1 file changed, 5 insertions(+), 13 deletions(-)

    Index: b/drivers/ide/ide.c
    ===================================================================
    --- a/drivers/ide/ide.c
    +++ b/drivers/ide/ide.c
    @@ -155,22 +155,14 @@ EXPORT_SYMBOL_GPL(ide_port_unregister_de
    * ide_unregister - free an IDE interface
    * @hwif: IDE interface
    *
    - * Perform the final unregister of an IDE interface. At the moment
    - * we don't refcount interfaces so this will also get split up.
    + * Perform the final unregister of an IDE interface.
    *
    * Locking:
    - * The caller must not hold the IDE locks
    - * The drive present/vanishing is not yet properly locked
    - * Take care with the callbacks. These have been split to avoid
    - * deadlocking the IDE layer. The shutdown callback is called
    - * before we take the lock and free resources. It is up to the
    - * caller to be sure there is no pending I/O here, and that
    - * the interface will not be reopened (present/vanishing locking
    - * isn't yet done BTW). After we commit to the final kill we
    - * call the cleanup callback with the ide locks held.
    + * The caller must not hold the IDE locks.
    *
    - * Unregister restores the hwif structures to the default state.
    - * This is raving bonkers.
    + * It is up to the caller to be sure there is no pending I/O here,
    + * and that the interface will not be reopened (present/vanishing
    + * locking isn't yet done BTW).
    */

    void ide_unregister(ide_hwif_t *hwif)

    \
     
     \ /
      Last update: 2008-12-16 20:35    [W:0.046 / U:269.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site