Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [Patch 3/3] via-sdmmc: via-sdmmc.h | Date | Tue, 16 Dec 2008 13:25:58 +0100 |
| |
On Tuesday 16 December 2008, JosephChan@via.com.tw wrote: > Header file of VIA MSP SD/MMC card reader driver. >
The order of your patches is reversed, you add the Kconfig/Makefile changes last so that the tree stays 'bisectable', i.e. you don't have a broken build in the middle between your patches.
Since your header file is not an interface but only used in a single source file, I would also suggest merging it into the main via-sdmmc.c file, add changing Kconfig/Makefile in the same patch.
Arnd <><
| |