lkml.org 
[lkml]   [2008]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [mmotm-2008-12-11-15-20] __unsafe() not defined.
    On Fri, 12 Dec 2008 09:40:41 -0500
    Neil Horman <nhorman@tuxdriver.com> wrote:

    > On Thu, Dec 11, 2008 at 06:17:33PM -0800, Andrew Morton wrote:
    > > On Fri, 12 Dec 2008 11:09:26 +0900 Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp> wrote:
    > >
    > > > I got this compilation error using gcc (GCC) 3.3.5 (Debian 1:3.3.5-13).
    > > >
    > > > drivers/pci/hotplug/ibmphp_core.c: In function `ibmphp_init':
    > > > drivers/pci/hotplug/ibmphp_core.c:1409: error: implicit declaration of function `__unsafe'
    > > > make[3]: *** [drivers/pci/hotplug/ibmphp_core.o] Error 1
    > > > make[2]: *** [drivers/pci/hotplug] Error 2
    > > > make[1]: *** [drivers/pci] Error 2
    > > > make: *** [drivers] Error 2
    > > >
    > > > "grep -Fr __unsafe ." shows only one line.
    > > >
    > > > ./drivers/pci/hotplug/ibmphp_core.c: __unsafe(THIS_MODULE);
    > > >
    > > > Where is __unsafe defined?
    > > >
    > >
    > > hm, I wonder what that was all about.
    > >
    > > I'll drop ibmphp-fix-module-ref-count-underflow.patch, thanks.

    It is fortunate indeed that I mentioned the old patch name in my email.

    >
    >
    > Apologies, I was working with an old tree. __unsafe has been deprecated. To
    > accomplish the functionality of unsafe, we simply need to not register an exit
    > routine, as per Adrian Bunks commit when __unsafe was removed. I'm leaving the
    > ibmphp_exit function in place though, just in case the author decides later that
    > it is in fact safe to remove.
    >
    > New patch attached.
    >
    > Regards
    > Neil
    >
    > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
    >
    >
    > ibmphp_core.c | 5 -----
    > 1 file changed, 5 deletions(-)

    Because otherwise it would have been rather difficult for me to locate
    the changelog.

    Oh dear, the original changelog is now wrong.

    >
    > diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
    > index c892daa..633e743 100644
    > --- a/drivers/pci/hotplug/ibmphp_core.c
    > +++ b/drivers/pci/hotplug/ibmphp_core.c
    > @@ -1402,10 +1402,6 @@ static int __init ibmphp_init(void)
    > goto error;
    > }
    >
    > - /* lock ourselves into memory with a module
    > - * count of -1 so that no one can unload us. */
    > - module_put(THIS_MODULE);
    > -
    > exit:
    > return rc;
    >
    > @@ -1423,4 +1419,3 @@ static void __exit ibmphp_exit(void)
    > }
    >
    > module_init(ibmphp_init);
    > -module_exit(ibmphp_exit);

    So I won't be applying this.



    \
     
     \ /
      Last update: 2008-12-16 01:39    [W:0.027 / U:32.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site