Messages in this thread | | | Date | Sun, 14 Dec 2008 16:57:34 +0100 | From | Thomas Hellström <> | Subject | Re: BUG: via_drmclient.h is referenced but does not exist |
| |
Hi!
The intention is for via_drm.h to be self-containing when included both for a kernel build and for a user-space build. In this particular case, via_drmclient.h lives in the user-space clients and includes stdint.h to get access to uint32_t and friends.
Of course, the user-space clients could #include "uint32.h" #include "via_drm.h"
but shouldn't really the tools be mimicing what the compiler does in this case?
/Thomas
Sam Ravnborg wrote: > Hi David et al. > > After improving the headers_check.pl script to do a > check for files included with: > > #include "foo.h" > > it reported the following error: > > /home/sam/kernel/knext.git/usr/include/drm/via_drm.h:34: included file '/home/sam/kernel/knext.git/usr/include/drm/via_drmclient.h' is not exported > > And indeed the file via_drmclient.h does not exist in the kernel source. > We do not see any issue in the kernel as the include is guarded by: > > #ifndef __KERNEL__ > #include "via_drmclient.h" > #endif > > But referring to a non-existing file is not the right thing to to. > > We need this check as we have several places where we do: > > #include "foo.h" > > in our exported headers. > > So we need to fix drm somehow. > > The headers_check.pl patch is included for reference. > >
| |