Messages in this thread | | | From | David Brownell <> | Subject | Re: GPIO: Fix probe() error return in gpio driver probes | Date | Sun, 14 Dec 2008 16:11:17 -0800 |
| |
On Sunday 14 December 2008, Ben Dooks wrote: > Has anyone reveiwed this patch? Are there any comments, or can this > be commited at somepoint (even if it is during the next merge window)?
I was thinking that -EINVAL is almost the least informative diagnostic code possible, since so many places return it that it's usually hard to find out *which* invalid parameter triggered ...
Is there a less-overloaded code you could return?
I have no issue with the patch other than that.
- Dave
| |