lkml.org 
[lkml]   [2008]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rtc-linux] Re: [PATCH 4/7] rtc: PCF50633 rtc driver
On Mon, 15 Dec 2008 03:34:30 +0530
Balaji Rao <balajirrao@openmoko.org> wrote:

> Hmm. This patch is included in [PATCH 1/7] of the series - which
> implements the core driver. This core driver needs this file to compile
> and not including there is going to break the bisectability of the
> series. Isn't this what I'm supposed to do ? Please correct me if I'm
> wrong.

ok, then don't break.

> > > + pcf = platform_get_drvdata(pdev);
> >
> > uh? where did you set up the pointer?
> >
> >
> > > + /* Set up IRQ handlers */
> > > + pcf->irq_handler[PCF50633_IRQ_ALARM].handler = pcf50633_rtc_irq;
> > > + pcf->irq_handler[PCF50633_IRQ_SECOND].handler = pcf50633_rtc_irq;
> > > +
> > > + pcf->rtc.rtc_dev = rtc;
> >
> > ??
> >
>
> It's done in the core driver - [PATCH 1/7] of this series.

mm. that's strange. a platform driver is supposed to receive informational
structures (regions, irqs, ...) and init driver data by itself. you shouldn't need
to mess with the drvdata pointer.

I do not also feel fine with the irq handlers setup. Your core should export
a function for irq registration.

> Thank you for the review. Will send again after resolving the issues.

thanks for your contribution. you are doing great things at openmoko.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it



\
 
 \ /
  Last update: 2008-12-14 23:25    [W:0.047 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site