lkml.org 
[lkml]   [2008]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] remove linux/hardirq.h from asm-generic/local.h
    On Sun, Dec 14, 2008 at 09:58:03AM -0800, Andrew Morton wrote:
    > On Sun, 14 Dec 2008 13:39:41 +0000 Russell King <rmk+lkml@arm.linux.org.uk> wrote:
    >
    > > While looking at reducing the amount of architecture namespace pollution
    > > in the generic kernel, I found that asm/irq.h is included in the vast
    > > majority of compilations on ARM (around 650 files.)
    > >
    > > Since asm/irq.h includes a sub-architecture include file on ARM, this
    > > causes a negative impact on the ccache's ability to re-use the build
    > > results from other sub-architectures, so we have a desire to reduce
    > > the dependencies on asm/irq.h.
    > >
    > > It turns out that a major cause of this is the needless include of
    > > linux/hardirq.h into asm-generic/local.h. The patch below removes this
    > > include, resulting in some 250 to 300 files (around half) of the kernel
    > > then omitting asm/irq.h.
    > >
    > > My test builds still succeed, provided two ARM files are fixed
    > > (arch/arm/kernel/traps.c and arch/arm/mm/fault.c) - so there may be
    > > negative impacts for this on other architectures.
    > >
    > > Note that x86 does not include asm/irq.h nor linux/hardirq.h in its
    > > asm/local.h, so this patch can be viewed as bringing the generic version
    > > into line with the x86 version.
    >
    > Sure. Includes are easy to add and hard to remove. I'll queue it up
    > and see if there's fallout.

    Thanks, I've committed to my git tree the addition of linux/hardirq.h to
    those two files I mentioned above. I guess at some point you'll pick
    those up to prevent build errors on ARM?

    > > From: Russell King <rmk+lkml@arm.linux.org.uk>
    > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    >
    > that will result in the two rmk's getting separate akpm spam, different
    > Author from Signer-offer, etc. Adding an explicit From: line would
    > improve things.

    If they're sent as the same email, it doesn't matter.

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of:


    \
     
     \ /
      Last update: 2008-12-14 20:53    [W:0.026 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site