lkml.org 
[lkml]   [2008]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] x86: entry_64 - introduce FTRACE_ frame macro
    [Frédéric Weisbecker - Sat, Dec 13, 2008 at 03:46:03PM +0100]
    | 2008/12/13 Cyrill Gorcunov <gorcunov@gmail.com>:
    | > [Steven Rostedt - Fri, Dec 12, 2008 at 04:56:47PM -0500]
    | > ...
    | > | > Steve, here is how it could look like:
    | > | > (I liked first proposal more :)
    | > |
    | > | I see the confusion. In ftrace.h the function graph tracer config is not
    | > | inside CONFIG_FUNCTION_TRACER, even though it is dependent on it (or
    | > | was). OK, just do your first proposal then.
    | > |
    | > | -- Steve
    | > |
    | >
    | > ok, I sent it yesterday as
    | >
    | > http://lkml.org/lkml/2008/12/12/301
    | > [PATCH] x86: entry_64 - introduce FTRACE_ frame macro v2
    | >
    | > Ingo, will you pick it up?
    | >
    | > - Cyrill -
    | >
    |
    | Hi,
    |
    | Looks good and clarify the asm bits.
    |
    | I wonder if the function_graph_tracer should continue to necessarily
    | depend on the function tracer.
    | It was more simplier to do so but perhaps that could be avoided with
    | small modifications.
    |

    Hi Frédéric,

    I didn't play with tracer internals since was more concerned about
    asm part of code. If you find that we better should introduce
    additional deps here or change a "deps graph" itself - I think it
    will be easy to place a new patch on top of this (or replace my
    patch) :)

    The only thing I would change in mine patch is -- subq/addq $0x38, %rsp
    since the following code uses decimal system but not a big deal anyway.

    - Cyrill -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-12-13 16:19    [W:0.025 / U:88.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site