lkml.org 
[lkml]   [2008]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/3] ide: add ide_[un]lock_hwgroup() helpers
Date

[ Sorry for the late reply. ]

On Wednesday 19 November 2008, Michael Schmitz wrote:
> > - while (!hwgroup->busy) {
> > - hwgroup->busy = 1;
> > - /* for atari only */
> > - ide_get_lock(ide_intr, hwgroup);
> > + while (!ide_lock_hwgroup(hwgroup)) {
>
> Something I've run into while working on the locking stuff: what happens if the
> above ide_lock_hwgroup(hwgroup) sleeps for long enough to trigger the request
> timer?

AFAICS this happens before the hwgroup timeout timer is armed and IDE is not
using block layer request timers yet so we should be fine here..

Thanks,
Bart


\
 
 \ /
  Last update: 2008-12-14 00:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog