lkml.org 
[lkml]   [2008]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, bts: fix build error

* Metzger, Markus T <markus.t.metzger@intel.com> wrote:

> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@elte.hu]
> >Sent: Freitag, 12. Dezember 2008 08:23
> >To: Metzger, Markus T
>
> > i fixed a build failure via the commit below - but the recursion in
> > that code is really nasty. Could you please clean it all up to plain
> > flat code?
>
> Sure.
>
> How could I find those things myself? Gcc 4.3.0 does not even give a
> warning for a defconfig build. Is there a config option I should set?

Gcc 4.3.0 is too new for that build failure ;-) -tip testing involves
testing with a couple of older compilers as well. This failure was with
4.2.2 iirc.

You generally shouldnt worry about that too much, as long as it built
fine on your config and the code is reasonably clean.

Ingo


\
 
 \ /
  Last update: 2008-12-12 10:03    [from the cache]
©2003-2011 Jasper Spaans