lkml.org 
[lkml]   [2008]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: Fix LSF default inconsistency
Hi Jens,

On Thu, 11 Dec 2008 13:50:01 +0100, Jens Axboe wrote:
> Oh right, that's pretty dumb. Lets just do the former, then a later
> patch can replace it completely if wanted.
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 1ab7c15..a785e65 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -23,22 +23,22 @@ menuconfig BLOCK
>
> if BLOCK
>
> +config LSF
> + bool
> +
> config LBD
> - bool "Support for Large Block Devices"
> + bool "Support for Large Block Devices and files"

It might be the right time to drop the extra capital letters, for
consistency.

> depends on !64BIT
> + select LSF
> help
> - Enable block devices of size 2TB and larger.
> + Enable block devices or files of size 2TB and larger.
>
> This option is required to support the full capacity of large
> (2TB+) block devices, including RAID, disk, Network Block Device,
> Logical Volume Manager (LVM) and loopback.
> -
> - For example, RAID devices are frequently bigger than the capacity
> - of the largest individual hard drive.
> -
> - This option is not required if you have individual disk drives
> - which total 2TB+ and you are not aggregating the capacity into
> - a large block device (e.g. using RAID or LVM).
> +
> + This option also enables support for single files larger than
> + 2TB.
>
> If unsure, say N.
>
> @@ -57,15 +57,6 @@ config BLK_DEV_IO_TRACE
>
> If unsure, say N.
>
> -config LSF
> - bool "Support for Large Single Files"
> - depends on !64BIT
> - help
> - Say Y here if you want to be able to handle very large files (2TB
> - and larger), otherwise say N.
> -
> - If unsure, say Y.
> -
> config BLK_DEV_BSG
> bool "Block layer SG support v4 (EXPERIMENTAL)"
> depends on EXPERIMENTAL
>

Acked-by: Jean Delvare <khali@linux-fr.org>

As a side note, someone will have to tell me why changing the value of
option LSF triggers a full kernel rebuild.

--
Jean Delvare


\
 
 \ /
  Last update: 2008-12-12 08:51    [from the cache]
©2003-2011 Jasper Spaans