lkml.org 
[lkml]   [2008]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86, bts: fix build error

    Markus,

    i fixed a build failure via the commit below - but the recursion in that
    code is really nasty. Could you please clean it all up to plain flat
    code?

    Ingo

    ----------------->
    From ffc2238af8431d930d2c15f16feecf1fd6d75642 Mon Sep 17 00:00:00 2001
    From: Ingo Molnar <mingo@elte.hu>
    Date: Fri, 12 Dec 2008 08:21:19 +0100
    Subject: [PATCH] x86, bts: fix build error

    Impact: build fix

    arch/x86/kernel/ds.c: In function 'ds_request':
    arch/x86/kernel/ds.c:236: sorry, unimplemented: inlining failed in call to 'ds_get_context': recursive inlining

    but the recursion here is scary ...

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    ---
    arch/x86/kernel/ds.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
    index f058300..dc1e712 100644
    --- a/arch/x86/kernel/ds.c
    +++ b/arch/x86/kernel/ds.c
    @@ -232,7 +232,7 @@ static DEFINE_PER_CPU(struct ds_context *, system_context_array);

    #define system_context per_cpu(system_context_array, smp_processor_id())

    -static inline struct ds_context *ds_get_context(struct task_struct *task)
    +static struct ds_context *ds_get_context(struct task_struct *task)
    {
    struct ds_context **p_context =
    (task ? &task->thread.ds_ctx : &system_context);

    \
     
     \ /
      Last update: 2008-12-12 08:27    [W:0.033 / U:179.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site