Messages in this thread | | | Date | Sat, 13 Dec 2008 01:29:35 +0100 | From | "Hans J. Koch" <> | Subject | Re: [PATCH 1/1] Userspace I/O (UIO): Add support for userspace DMA |
| |
On Fri, Dec 12, 2008 at 06:25:12PM +0100, Peter Zijlstra wrote: > On Fri, 2008-12-05 at 16:32 -0800, Edward Estabrook wrote: > > > Well, UIO already rapes the mmap interface by using the "offset" parameter to > > > pass in the number of the mapping. > > > > Exactly. > > Had I known about it then, I'd NAK'd it, but I guess now that its > already merged changing it will be hard :/
It was in -mm for half a year before it went to mainline in 2.6.23, the documentation being present all the time. It was discussed intensively on lkml, and several core kernel developers reviewed it. The special use of the mmap() offset parameter was never even mentioned by anybody. I remember that so well because I actually expected critizism, but everybody was fine with it. And to be honest, even though it's unusual, I still find it a good solution.
Thanks, Hans
| |