lkml.org 
[lkml]   [2008]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] x86: entry_64 - introduce FTRACE_ frame macro
    [Steven Rostedt - Fri, Dec 12, 2008 at 04:22:49PM -0500]
    |
    | On Fri, 12 Dec 2008, Cyrill Gorcunov wrote:
    |
    | > [Steven Rostedt - Fri, Dec 12, 2008 at 03:52:56PM -0500]
    | > |
    | > ...
    | > | You can put them in arch/x86/include/asm/ftrace.h That's assembly safe.
    | > |
    | > | -- Steve
    | > |
    | >
    | > Yep, while you were typing the message I was testing the change :)
    | > Do you like it?
    | >
    | > - Cyrill -
    | >
    | > ---
    | > arch/x86/include/asm/ftrace.h | 29 ++++++++++++++++++++-
    | > arch/x86/kernel/entry_64.S | 57 +++++-------------------------------------
    | > 2 files changed, 35 insertions(+), 51 deletions(-)
    | >
    | > Index: linux-2.6.git/arch/x86/include/asm/ftrace.h
    | > ===================================================================
    | > --- linux-2.6.git.orig/arch/x86/include/asm/ftrace.h
    | > +++ linux-2.6.git/arch/x86/include/asm/ftrace.h
    | > @@ -1,6 +1,33 @@
    | > #ifndef _ASM_X86_FTRACE_H
    | > #define _ASM_X86_FTRACE_H
    | >
    | > +#ifdef __ASSEMBLY__
    |
    | Why add assembly condition? We only want this if CONFIG_FUNCTION_TRACER
    | is enabled, right? We could combine it with the current #ifndef inside
    | the CONFIG_FUNCTION_TRACER. But I would make do:
    |
    | #ifdef __ASSEMBLY__
    | <your stuff>
    | #else
    | < C stuff >
    | #endif
    |
    | -- Steve
    ...

    OK, will back shortly.

    - Cyrill -


    \
     
     \ /
      Last update: 2008-12-12 22:31    [W:0.032 / U:150.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site