Messages in this thread | | | Date | Thu, 11 Dec 2008 14:42:28 +0900 | From | "Nguyen Anh Quynh" <> | Subject | Re: [PATCH] fix calls to request_module() |
| |
On Thu, Dec 11, 2008 at 2:00 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Thu, Dec 11, 2008 at 01:23:36PM +0900, Nguyen Anh Quynh wrote: > >> So I checked again by fixing the code that should be compiled >> (sound/core/sound.c), and can confirm that without the patch we got >> warning like below: >> >> sound/core/sound.c: In function 'snd_request_other': >> sound/core/sound.c:91: warning: format not a string literal and no >> format arguments > > Ah, but that's different. Take a look at that warning and think _why_ > it is given and what is it about. Getting an untrusted string as > format argument is a real security hole, but it has nothing to do > with a pile of cases in your patch.
Yes, clearly the warning is to warn us about potential format string bugs. But I agree that there are a lot of false possitives.
My patch is mainly to make gcc happy.
Thanks, Q
| |