lkml.org 
[lkml]   [2008]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH, v2] ext3: ensure link targets are NULL-terminated
    Ensure link targets are NUL-terminated, even if corrupted on-disk.

    Signed-off-by: Duane Griffin <duaneg@dghda.com>
    ---

    V2: terminate when the link is read instead of every time it is
    followed, as suggested by Dave Kleikamp.

    diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
    index f8424ad..c168781 100644
    --- a/fs/ext3/inode.c
    +++ b/fs/ext3/inode.c
    @@ -2817,9 +2817,10 @@ struct inode *ext3_iget(struct super_block *sb, unsigned long ino)
    inode->i_op = &ext3_dir_inode_operations;
    inode->i_fop = &ext3_dir_operations;
    } else if (S_ISLNK(inode->i_mode)) {
    - if (ext3_inode_is_fast_symlink(inode))
    + if (ext3_inode_is_fast_symlink(inode)) {
    inode->i_op = &ext3_fast_symlink_inode_operations;
    - else {
    + ((char *) ei->i_data)[inode->i_size] = '\0';
    + } else {
    inode->i_op = &ext3_symlink_inode_operations;
    ext3_set_aops(inode);
    }
    --
    "I never could learn to drink that blood and call it wine" - Bob Dylan

    \
     
     \ /
      Last update: 2008-12-11 23:29    [W:0.020 / U:39.652 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site