lkml.org 
[lkml]   [2008]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 68/83] x86: HPET: convert WARN_ON to WARN_ON_ONCE
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Matt Fleming <mjf@gentoo.org>

    commit 1de5b0854623d30d01d72cd4ea323eb5f39d1f16 upstream.

    It is possible to flood the console with call traces if the WARN_ON
    condition is true because of the frequency with which this function is
    called.

    Signed-off-by: Matt Fleming <mjf@gentoo.org>
    Cc: mingo@elte.hu
    Cc: venkatesh.pallipadi@intel.com
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/hpet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/hpet.c
    +++ b/arch/x86/kernel/hpet.c
    @@ -283,7 +283,7 @@ static int hpet_legacy_next_event(unsign
    * what we wrote hit the chip before we compare it to the
    * counter.
    */
    - WARN_ON((u32)hpet_readl(HPET_T0_CMP) != cnt);
    + WARN_ON_ONCE((u32)hpet_readl(HPET_T0_CMP) != cnt);

    return (s32)((u32)hpet_readl(HPET_COUNTER) - cnt) >= 0 ? -ETIME : 0;
    }


    \
     
     \ /
      Last update: 2008-12-11 20:45    [W:0.020 / U:60.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site