lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix calls to request_module()
    On Wed, Dec 10, 2008 at 08:14:55PM -0800, Andrew Morton wrote:
    > On Thu, 11 Dec 2008 04:01:18 +0000 Al Viro <viro@ZenIV.linux.org.uk> wrote:
    >
    > > On Thu, Dec 11, 2008 at 12:35:21PM +0900, Nguyen Anh Quynh wrote:
    > > > Hi,
    > > >
    > > > The request_module() function should always have the 1st param as a
    > > > format argument. So for example, request_module("i2c-powermac") should
    > > > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc
    > > > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This
    > > > patch fixes them all in linus-git tree.
    > >
    > > ... and it doesn't address the underlying problems at all. A string literal
    > > without a single % in it is a perfectly sane and valid format. _Why_ are
    > > we getting these warning?
    >
    > extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2)));
    >
    > ?

    ... and request_module("i2c-powermac") should be perfectly valid, shouldn't it?
    I mean, I do not believe that any gcc version would start spewing warnings
    of
    printf("-- \n");
    and its ilk...


    \
     
     \ /
      Last update: 2008-12-11 05:51    [W:0.023 / U:2.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site