Messages in this thread |  | | Date | Wed, 10 Dec 2008 19:31:05 -0800 | | From | Greg KH <> | | Subject | Re: [PATCH] Fix VMI crash on boot in 2.6.27+ kernels |
| |
On Wed, Dec 10, 2008 at 04:20:06PM -0800, Yinghai Lu wrote: > Zachary Amsden wrote: > > On Tue, 2008-12-09 at 17:15 -0800, Yinghai Lu wrote: > > > >> you can not move that late, > >> > >> parse_setup_data==>early_memremap==>__early_ioremap > > > > How does this look? > > > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index 9d5674f..4c381cb 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -794,6 +794,11 @@ void __init setup_arch(char **cmdline_p) > printk(KERN_INFO "Command line: %s\n", boot_command_line); > #endif > > +#ifdef CONFIG_VMI > + /* VMI may relocate the fixmap; do this before touching ioremap area */ > + vmi_init(); > +#endif
Shouldn't the #ifdef not be needed here if the .h files are set up properly for the vmi_init prototype? Please try to keep them out of .c files wherever possible.
thanks,
greg k-h
|  |