lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system_hash
From
Date
On Wed, 2008-12-10 at 18:27 +0000, Catalin Marinas wrote:
> @@ -4570,6 +4571,8 @@ void *__init alloc_large_system_hash(const char *tablename,
> if (_hash_mask)
> *_hash_mask = (1 << log2qty) - 1;
>
> + memleak_alloc(table, size, 1, GFP_ATOMIC);
> +
> return table;
> }

Why is this sucker GFP_ATOMIC?

Since alloc_large_system_hash() is using bootmem (and is called early),
I'm a little surprised that it is OK to call into memleak_alloc() which
uses kmem_cache_alloc(). Is the slab even set up at this point?

-- Dave



\
 
 \ /
  Last update: 2008-12-10 20:07    [from the cache]
©2003-2011 Jasper Spaans