lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: make printk messges more searchable
On Wed, 10 Dec 2008, Oliver Neukum wrote:

> Am Mittwoch, 10. Dezember 2008 10:42:17 schrieb Laurent Pinchart:
> > Hi Wu,
> >
> > On Wednesday 10 December 2008, Wu Fengguang wrote:
> > > Make USB printk messages long and straightforward. One of these
> > > decorated USB error messages cost me some smart efforts to locate.
> >
> > That would make the code break the 80 columns limit.
> >
> > From "Documentation/CodingStyle":
> >
> > "The limit on the length of lines is 80 columns and this is a strongly
> > preferred limit."
>
> Too rigid an application is bad. The kernel must be greppable.

The kernel is greppable in either case. It's foolish to rigidly insist
that long strings must not be broken. And don't forget that some
strings are created dynamically (with %s specifiers, for instance).
How are you going to grep for them?

It's also worth pointing out that much of the source code in usbcore
tends to indent continuation lines by two extra tab stops. This isn't
done all the time, admittedly. But deliberately changing the code so
that continuations use only one tab stop feels like a bad idea -- one
extra tab stop looks too much like a nested statement.

Alan Stern



\
 
 \ /
  Last update: 2008-12-10 16:41    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site