Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [ltt-dev] [PATCH] Poll : introduce poll_wait_exclusive() new function | Date | Tue, 2 Dec 2008 13:44:51 +0900 (JST) |
| |
> > Any thought ? > > That looks fine, but before waving the Thundering Herd flag some > performance numbers should be given IMO, considerng also that this is a > rather particular use of the poll subsystem. > Eventually, isn't something like the patch below better than adding custom > case names to poll_wait() ALA poll_wait_LONGNAMESFOLLOW()? > That way you can pass your own queueing function: > > poll_wait_qfunc(file, head, pt, add_wait_queue_exclusive);
make sense. I don't found any bug in your patch.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Thanks.
| |