lkml.org 
[lkml]   [2008]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] clarify usage expectations for cnt32_to_63()
On Sun, Nov 09, 2008 at 08:34:23AM -0500, Nicolas Pitre wrote:
> Do you really have such instances where multiple call sites are needed?
> That sounds even more confusing to me than the current model. Better
> encapsulate the usage of this macro within some function which has a
> stronger meaning, such as sched_clock(), and call _that_ from multiple
> sites instead.

What if sched_clock() is inline and uses cnt32_to_63()? I think that's
where the problem lies. Better add a comment that it shouldn't be used
inside another inline function.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:


\
 
 \ /
  Last update: 2008-11-09 14:47    [W:0.116 / U:3.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site