Messages in this thread | | | Date | Sun, 09 Nov 2008 00:36:01 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RFC PATCH] sparse_irq aka dyn_irq |
| |
Ingo Molnar wrote: > >> +++ linux-2.6/arch/x86/mm/init_32.c >> @@ -66,6 +66,7 @@ static unsigned long __meminitdata table >> static unsigned long __meminitdata table_top; >> >> static int __initdata after_init_bootmem; >> +int after_bootmem; >> >> static __init void *alloc_low_page(unsigned long *phys) >> { >> @@ -987,6 +988,8 @@ void __init mem_init(void) >> >> set_highmem_pages_init(); >> >> + after_bootmem = 1; > > this hack can go away once we have a proper percpu_alloc() that can be > used early enough. >
Also, flags should be "bool". We're not aggressively going after old code to convert it, but new code should use "bool".
-hpa
| |