Messages in this thread | | | Date | Sun, 9 Nov 2008 09:14:27 -0800 | From | Arjan van de Ven <> | Subject | Re: [PATCH 3/8] drivers/media: use ARRAY_SIZE |
| |
On Sun, 9 Nov 2008 17:55:03 +0100 (CET) Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk> > > ARRAY_SIZE is more concise to use when the size of an array is > divided by the size of its type or the size of its first element.
Hi, looking at your patch, I don't think I agree it's just blindly the right thing to do.
> - *count = sizeof(RegAddr) / sizeof(u8); > + *count = ARRAY_SIZE(RegAddr);
really. ARRAY_SIZE doesn't appear to be an improvement here..
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |