Messages in this thread | | | Date | Sat, 08 Nov 2008 17:39:17 +0800 | From | Li Zefan <> | Subject | Re: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2) |
| |
> +static int mem_cgroup_hierarchy_write(struct cgroup *cont, struct cftype *cft, > + u64 val) > +{ > + int retval = 0; > + struct mem_cgroup *mem = mem_cgroup_from_cont(cont); > + > + if (val == 1) { > + if (list_empty(&cont->children))
cgroup_lock should be held before checking cont->children.
> + mem->use_hierarchy = val; > + else > + retval = -EBUSY; > + } else if (val == 0) {
And code duplicate.
> + if (list_empty(&cont->children)) > + mem->use_hierarchy = val; > + else > + retval = -EBUSY; > + } else > + retval = -EINVAL; > + > + return retval; > +} > +
| |