lkml.org 
[lkml]   [2008]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][mm] [PATCH 4/4] Memory cgroup hierarchy feature selector (v2)
    > +static int mem_cgroup_hierarchy_write(struct cgroup *cont, struct cftype *cft,
    > + u64 val)
    > +{
    > + int retval = 0;
    > + struct mem_cgroup *mem = mem_cgroup_from_cont(cont);
    > +
    > + if (val == 1) {
    > + if (list_empty(&cont->children))

    cgroup_lock should be held before checking cont->children.

    > + mem->use_hierarchy = val;
    > + else
    > + retval = -EBUSY;
    > + } else if (val == 0) {

    And code duplicate.

    > + if (list_empty(&cont->children))
    > + mem->use_hierarchy = val;
    > + else
    > + retval = -EBUSY;
    > + } else
    > + retval = -EINVAL;
    > +
    > + return retval;
    > +}
    > +



    \
     
     \ /
      Last update: 2008-11-08 10:45    [W:0.020 / U:0.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site