lkml.org 
[lkml]   [2008]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 03/23] edac cell: fix incorrect edac_mode
    2.6.26-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    commit 3b274f44d2ca05f719fe39947b6a5293a2dbd8fd upstream

    The cell_edac driver is setting the edac_mode field of the csrow's to an
    incorrect value, causing the sysfs show routine for that field to go out
    of an array bound and Oopsing the kernel when used.

    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Doug Thompson <dougthompson@xmission.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/edac/cell_edac.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/edac/cell_edac.c
    +++ b/drivers/edac/cell_edac.c
    @@ -141,7 +141,7 @@ static void __devinit cell_edac_init_csr
    csrow->nr_pages = (r.end - r.start + 1) >> PAGE_SHIFT;
    csrow->last_page = csrow->first_page + csrow->nr_pages - 1;
    csrow->mtype = MEM_XDR;
    - csrow->edac_mode = EDAC_FLAG_EC | EDAC_FLAG_SECDED;
    + csrow->edac_mode = EDAC_SECDED;
    dev_dbg(mci->dev,
    "Initialized on node %d, chanmask=0x%x,"
    " first_page=0x%lx, nr_pages=0x%x\n",
    --


    \
     
     \ /
      Last update: 2008-11-08 00:27    [W:0.036 / U:0.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site