Messages in this thread | | | Date | Fri, 7 Nov 2008 13:04:35 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Many headers included multiple times |
| |
On Sat, 1 Nov 2008 11:15:38 +0000 Steve Kemp <steve.30-11-2008.date@steve.org.uk> wrote:
> There are many source files which include the same header multiple > times. Minimal initial patch included here, will submit the rest > shortly if there is interest. > > Quick tool to detect these: http://www.steve.org.uk/Software/kernel/
I flee in terror from patches like this because of the risk that someone else will delete the _other_ #include, and this patch still applies OK, so we end up removing both #includes and things break. This has happened before.
Thought: if the patch were to delete one #include and to then move the other one to a different position in the #include order then this couldn't happen.
| |