Messages in this thread | | | Date | Fri, 7 Nov 2008 10:46:11 -0800 | Subject | Re: [patch] add /proc/pid/stack to dump task's stack trace | From | Paul Menage <> |
| |
On Fri, Nov 7, 2008 at 10:38 AM, Ken Chen <kenchen@google.com> wrote: > > Here is a patch convert to seq_file using proc_single_show() helper. > I don't see it to be any superior than what was before using > snprintf(). seq_read also allocate one page for printf buffer, so > functionally it is the same (perhaps a little bit better because it > can use the whole page, compare to PROC_BLOCK_SIZE currently).
No - if you exceed the original buffer size, the seq_file system will double up the memory buffer and try again if necessary.
Paul
| |