lkml.org 
[lkml]   [2008]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU
>>> Ingo Molnar <mingo@elte.hu> 06.11.08 23:20 >>>
>
>* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>> Ingo Molnar wrote:
>>> where exactly is that use? My grep didnt show any users of pud_page().
>>> pud_page() was changed in an incompatible way, all users of it must be
>>> updated.
>>>
>>
>> pgd_page() uses it in pgtable-nopud.h, so any users of pgd_page()
>> also need to be looked at. It so happens the only user is
>> arch/x86/xen/mmu.c, which expects it to return the vaddr. Fixed
>> below.
>
>ah! asm-generic was missed by my grep. (and i suspect Jan missed it
>too)

Indeed - broken as it was I never even considered this could be used
somewhere in generic code.

>> Subject: xen: fix use of pgd_page now that it really does return a page
>
>applied to tip/x86/urgent, thanks!

And my thanks, too, Jeremy, for the quick spotting of the problem.

Jan



\
 
 \ /
  Last update: 2008-11-07 10:55    [W:0.035 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site