lkml.org 
[lkml]   [2008]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH]: ext4: fix big endian
    Date
    Am Donnerstag, 6. November 2008 schrieb Christoph Hellwig:
    > > I suspect that you want to do the le16_to_cpu() and _then_
    > > add the 1. Otherwise, adding 1 to a different byte order
    > > value won't do quite what is expected or hoped for...
    >
    > Yes. And if someone ran sparse over the code both the initial error
    > and this varaint would be trivial to spot..

    I think the problem is, that sparse now requires
    __CHECK_ENDIAN__
    to check for endianess problems. Seems that lots of people are not aware of
    this.

    Christian


    \
     
     \ /
      Last update: 2008-11-06 18:15    [W:0.019 / U:1.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site