lkml.org 
[lkml]   [2008]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: ext4: fix big endian
On Thu, Nov 06, 2008 at 11:06:25AM -0500, Peter Staubach wrote:
>> Index: kvm/fs/ext4/super.c
>> ===================================================================
>> --- kvm.orig/fs/ext4/super.c
>> +++ kvm/fs/ext4/super.c
>> @@ -1455,7 +1455,7 @@ static int ext4_fill_flex_info(struct su
>> /* We allocate both existing and potentially added groups */
>> flex_group_count = ((sbi->s_groups_count + groups_per_flex - 1) +
>> - ((sbi->s_es->s_reserved_gdt_blocks +1 ) <<
>> + (le16_to_cpu(sbi->s_es->s_reserved_gdt_blocks + 1) <<
>>
>
> I suspect that you want to do the le16_to_cpu() and _then_
> add the 1. Otherwise, adding 1 to a different byte order
> value won't do quite what is expected or hoped for...

Yes. And if someone ran sparse over the code both the initial error
and this varaint would be trivial to spot..



\
 
 \ /
  Last update: 2008-11-06 17:41    [W:0.072 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site