Messages in this thread | | | Subject | Re: [PATCH] SSB: make it depend on PCI | From | Johannes Berg <> | Date | Thu, 06 Nov 2008 12:22:53 +0100 |
| |
On Thu, 2008-11-06 at 06:15 -0500, Mike Frysinger wrote:
> while that may be the intent, it doesnt work today. > > drivers/ssb/main.c always includes linux/ssb/ssb.h > > linux/ssb/ssb.h always calls pci_dma_* functions > > arches that do not support PCI fail to build: > CC drivers/ssb/main.o > In file included from drivers/ssb/ssb_private.h:5, > from drivers/ssb/main.c:12: > include/linux/ssb/ssb.h: In function 'ssb_dma_mapping_error': > include/linux/ssb/ssb.h:430: error: implicit declaration of function 'pci_dma_mapping_error' > include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_cpu': > include/linux/ssb/ssb.h:475: error: implicit declaration of function 'pci_dma_sync_single_for_cpu' > include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_for_device': > include/linux/ssb/ssb.h:493: error: implicit declaration of function 'pci_dma_sync_single_for_device' > include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_cpu': > include/linux/ssb/ssb.h:517: error: implicit declaration of function 'dma_sync_single_range_for_cpu' > include/linux/ssb/ssb.h: In function 'ssb_dma_sync_single_range_for_device': > include/linux/ssb/ssb.h:538: error: implicit declaration of function 'dma_sync_single_range_for_device' > drivers/ssb/main.c: In function 'ssb_dma_set_mask': > drivers/ssb/main.c:1183: error: implicit declaration of function 'dma_set_mask'
That seems odd, shouldn't at least the dma_sync_* functions and dma_set_mask be supported?
There probably need to be ifdefs, if you look at those functions then you'll see that it depends on the bustype the device is on.
johannes [unhandled content-type:application/pgp-signature] | |