[lkml]   [2008]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 08/16] x86: Emergency virtualization disable function
Avi Kivity <> writes:

> Eduardo Habkost wrote:
>> We could move the set_virt_disable_func() calls to vmx.c and svm.c (on
>> hardware_setup/hardware_unsetup). One could argue that it is sort of a
>> coincidence that we need the code for both vmx and svm.
> I don't share this fear of function calls, but perhaps that's due to lack of
> experience with kdump.

Mostly I'm just afraid of extra complexity.

> If you want to be extra simple and safe, remove kvm from the equation. Make the
> disabling code part of kdump/emergency_restart and only rely on the convention
> that cr3.vmxe == vmxon.

> That has the advantage of working with other virtualization systems as well.

Sounds good.


 \ /
  Last update: 2008-11-06 11:27    [W:0.107 / U:4.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site