[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/18] libosd: OSDv1 Headers
On Wed, 2008-11-05 at 14:54 +0200, Boaz Harrosh wrote:
> >> + struct _osd_io_info {
> >> + struct bio *bio;
> >> + u64 total_bytes;
> >
> > u64(!)
> >
> Do you mean that I need to use __u64? or what do you mean?

He means you've used u64 in a header without actually including any file
that defines the typedef. Linux header files aren't supposed to depend
on include order. They're supposed to stand alone. The point is that
if I include just #include osd_initiator.h into an empty kernel file
it's not supposed to spit undefined errors.

Right at the moment the u64 probably works because blkdev.h #includes
the file which defines it, but you're not supposed to rely on that.


 \ /
  Last update: 2008-11-05 14:13    [W:0.064 / U:24.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site