lkml.org 
[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] IO mappings, #2

* Jonathan Corbet <corbet@lwn.net> wrote:

> Having looked at this some, I have one, tiny little suggestion:
>
> > +With this mapping object, individual pages can be mapped either
> > atomically +or not, depending on the necessary scheduling
> > environment. Of course, atomic +maps are more efficient:
> > +
> > + void *io_mapping_map_atomic_wc(struct io_mapping *mapping,
> > + unsigned long offset)
>
> Should the documentation for this function (perhaps the
> certainly-forthcoming kerneldoc comments :) mention loudly that this
> function uses KM_USER0? This isn't kmap(), and doesn't look much
> like it; someday some developer might get an ugly surprise when they
> try to use that slot simultaneously for something else.

definitely worth a comment.

Ingo


\
 
 \ /
  Last update: 2008-11-05 10:03    [W:0.096 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site