lkml.org 
[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] ALSA: cs5535audio: OLPC Analog Input and MIC Bias support
On Thu, Nov 6, 2008 at 6:31 AM, Andres Salomon <dilinger@queued.net> wrote:
>
> This adds support for the special cs5535audio features that OLPC XO-1s have.
> They support switching between analog and DC recording, and the MIC requires
> toggling V_REFOUT (which this patch renames to MIC Bias) to operate. There's
> also an EAPD tweak which is necessary for B3 and newer machines.
>
> All of this is enabled by CONFIG_OLPC (and CONFIG_SND_CS5535AUDIO, obviously).
>
> Signed-off-by: Andres Salomon <dilinger@debian.org>


Andres,

Looks okay. But can you send this patch split into 2 patches? One, the
original cs5535audio_olpc.c that I posted and your changes to it since
then. That'll make it easier for me to review.

Thanks,
jaya


\
 
 \ /
  Last update: 2008-11-06 01:25    [W:0.021 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site