lkml.org 
[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [Patch] Always include <linux/types.h>
[ Threading should have been broken.  Doh! ]

On Wed, 5 November 2008 20:23:12 +0300, Alexey Dobriyan wrote:
> On Wed, Nov 05, 2008 at 05:39:41PM +0100, Jörn Engel wrote:
> > Hardly any file in the kernel can be compiled without including
> > <linux/types.h>, directly or indirectly. And I'd wager a beer that
> > noone can find a non-trivial example. I couldn't.
>
> This is only going to slow down compilation and types.h is not causing much
> compilation problems, in fact, I can't recall a compilation problem due to
> types.h. Contary to config.h situation which was a pain.

My hope was actually to speed up compilation. If the average c file
includes 10 headers, on types.h will get included by most of them,
possibly multiple times. Each run after the first still has to parse
the whole file, just to drop everything between #ifndef _LINUX_TYPES_H
and #endif.

By passing types.h on the command line we can drop it from all headers
and only have to parse it once. Just the intermediate step of parsing
types.h 11 times instead of 10 will slow things down. By about .4% on
my not very beefy notebook.

Before:
real 4m33.241s
user 3m58.524s
sys 0m18.539s

After:
real 4m29.707s
user 3m59.674s
sys 0m18.182s

And while testing this I noticed that a_flags shouldn't include the
file. Updated patch below.

Jörn

--
to show off how geeky they were.
-- Rob Enderle

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index ea48b82..328f345 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -121,7 +121,8 @@ endif

c_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(KBUILD_CPPFLAGS) \
$(__c_flags) $(modkern_cflags) \
- -D"KBUILD_STR(s)=\#s" $(basename_flags) $(modname_flags)
+ -D"KBUILD_STR(s)=\#s" $(basename_flags) $(modname_flags) \
+ -include include/linux/types.h

a_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(KBUILD_CPPFLAGS) \
$(__a_flags) $(modkern_aflags)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2008-11-05 20:19    [W:0.112 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site