Messages in this thread | | | Date | Wed, 5 Nov 2008 08:33:34 -0800 | From | Greg KH <> | Subject | Re: [PATCH] UIO: only call pgprot_noncached if defined |
| |
On Wed, Nov 05, 2008 at 12:36:11PM +0100, Hans J. Koch wrote: > There seem to be archs that cannot easily implement a sensible > pgprot_noncached() function, so we should merge this patch. UIO doesn't > compile on these archs right now.
No, we should fix those arches to have that function at least NULLed out. Isn't there only one, Blackfin? Putting #ifdefs in .c files is not something we really want to do if at all possible.
thanks,
greg k-h
| |