lkml.org 
[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/14] x86: disable virt on kdump and emergency_restart
    On Wed, Nov 05, 2008 at 09:44:12AM -0500, Vivek Goyal wrote:
    > On Tue, Nov 04, 2008 at 06:54:04PM +0200, Avi Kivity wrote:
    > > Eduardo Habkost wrote:
    > >> Hi,
    > >>
    > >> This is a new version of the series to disabling virtualization on kdump,
    > >> now extended to do the same tricks on emergency_restart() if needed.
    > >>
    > >
    > > Looks good. If you me to push it upstream, I'll need kexec/kdump acks.
    > > Otherwise, ack for the kvm bits.
    >
    > Looks good to me from kdump perspective.
    >
    > Is there a way we can prevent any other module from using virt disable
    > callback incase kvm is not loaded?

    I think we can't prevent other modules from using the API. But 3rd-party
    modules deal with CPU virtualization extensions today won't live with
    KVM today, anyway. And between not living together with KVM and breaking
    kdump/reboot, and not living together with KVM and making kdump and
    reboot working, I the the latter looks better.

    But I see this as an orthogonal issue. If we include a "CPU virtualization
    extensions core API" in the future, it could simply keep the same
    emergency_virt_disable() API available for emergency_restart and kdump.

    --
    Eduardo


    \
     
     \ /
      Last update: 2008-11-05 16:09    [W:0.022 / U:30.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site