lkml.org 
[lkml]   [2008]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: Broken "cpualloc: the allocator" patch
    On Wed, 5 Nov 2008, Alexey Dobriyan wrote:

    > Same thing. For reference f622b9e43c8ba1902d4423bef9ae9d89b0254b45 aka
    > "cpualloc: the allocator".
    >
    > It's BUG_ON(!size) at mm/bootmem.c:438. At cpu_alloc_init():
    >
    > __per_cpu_start = ff...80555000
    > __per_cpu_end = ff...8055d3e0
    > UNIT_SIZE = 4
    > base_percpu_in_units = 8440
    > PERCPU_AREA_SIZE = 33760
    > nr_units = 0 (bang!)
    >
    > MODULES are off.

    Oww.. Ok we need to skip ahead to have a hunk from the second stage
    to make sure PERCPU_RESERVE_SIZE is always > 0.

    Signed-off-by: Christoph Lameter <cl@linux-foundation.org>

    Index: linux-2.6/include/linux/percpu.h
    ===================================================================
    --- linux-2.6.orig/include/linux/percpu.h 2008-11-05 07:41:22.134646124 -0600
    +++ linux-2.6/include/linux/percpu.h 2008-11-05 07:44:28.603155403 -0600
    @@ -44,11 +44,7 @@
    extern unsigned int percpu_reserve;
    /* Enough to cover all DEFINE_PER_CPUs in kernel, including modules. */
    #ifndef PERCPU_AREA_SIZE
    -#ifdef CONFIG_MODULES
    #define PERCPU_RESERVE_SIZE 8192
    -#else
    -#define PERCPU_RESERVE_SIZE 0
    -#endif

    #define PERCPU_AREA_SIZE \
    (__per_cpu_end - __per_cpu_start + percpu_reserve)

    \
     
     \ /
      Last update: 2008-11-05 14:49    [W:0.022 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site