lkml.org 
[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] rz1000: apply chipset quirks early
Hello, I wrote:

>> Index: b/drivers/ide/rz1000.c
>> ===================================================================
>> --- a/drivers/ide/rz1000.c
>> +++ b/drivers/ide/rz1000.c
>> @@ -22,34 +22,48 @@
>>
>> #define DRV_NAME "rz1000"
>>
>> -static void __devinit init_hwif_rz1000 (ide_hwif_t *hwif)
>> +static unsigned int __devinit rz1000_init_chipset(struct pci_dev *dev)

> Hm, this is not a real init_chipset() method and it does just one
> thing -- disables readahead, so rz1000_disable_readahead() or something
> of that sort seems like a better name...

Hm, 'unsigned' result type wasn't terribly helpful here as well. :-)

MBR, Sergei


\
 
 \ /
  Last update: 2008-11-04 19:59    [W:0.072 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site