lkml.org 
[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] ide: rework handling of serialized ports
Hello, I wrote:

>> Index: b/drivers/ide/ide-probe.c
>> ===================================================================
>> --- a/drivers/ide/ide-probe.c
>> +++ b/drivers/ide/ide-probe.c

> [...]

>> @@ -1436,10 +1398,8 @@ static void ide_init_port(ide_hwif_t *hw
>> }
>>
>> if ((d->host_flags & IDE_HFLAG_SERIALIZE) ||
>> - ((d->host_flags & IDE_HFLAG_SERIALIZE_DMA) && hwif->dma_base)) {
>> - if (hwif->mate)
>> - hwif->mate->serialized = hwif->serialized = 1;
>> - }
>> + ((d->host_flags & IDE_HFLAG_SERIALIZE_DMA) && hwif->dma_base))
>> + hwif->host_flags |= IDE_HFLAG_SERIALIZE;

> I don't see what use is forcing this flag at all here -- it doesn't
> seem to be checked only in init_irq() now, so this *if* could just be
> moved there...

Oops, rephrasing hurts sometimes: I meant "it seems", of course. :-)

MBR, Sergei


\
 
 \ /
  Last update: 2008-11-04 19:37    [W:1.055 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site