Messages in this thread Patch in this message | | | From | Rusty Russell <> | Subject | Re: mmotm 2008-11-29-01-53 uploaded | Date | Mon, 1 Dec 2008 15:07:33 +1030 |
| |
On Monday 01 December 2008 12:40:40 KAMEZAWA Hiroyuki wrote: > On Sat, 29 Nov 2008 01:59:56 -0800 > > akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2008-11-29-01-53 has been uploaded to > > > > http://userweb.kernel.org/~akpm/mmotm/ > > > > It contains the following patches against 2.6.28-rc6: > > Hi, in recent changes of linux-next.patch
Yep, it was mine. Latest linux-next should have the fix (sfr berated me for this bug earlier), which is below:
core_param: call these really, really early - fix
USB sets prefix to "", so there's no dot. We should really be using core_param for this.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> --- kernel/params.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/params.c b/kernel/params.c --- a/kernel/params.c +++ b/kernel/params.c @@ -634,7 +634,9 @@ static void __init param_sysfs_builtin(v continue; dot = strchr(kp->name, '.'); - BUG_ON(!dot); + /* FIXME: USB code sets prefix to "". Should use core_param */ + if (!dot) + continue; name_len = dot - kp->name + 1; strlcpy(modname, kp->name, name_len); kernel_add_sysfs_param(modname, kp, name_len);
| |