lkml.org 
[lkml]   [2008]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] small optimization to update_curr_rt

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2008-10-31 at 08:03 -0500, Dimitri Sivanich wrote:
> > A very minor improvement, but might it be better to check sched_rt_runtime(rt_rq)
> > before taking the rt_runtime_lock?
>
> Yes, I think its ok to do so.
>
> Like pointed out in the other thread, there are two races:
>
> - sched_rt_runtime() going to RUNTIME_INF, and that will be handled
> properly by sched_rt_runtime_exceeded()
>
> - sched_rt_runtime() going to !RUNTIME_INF, and here we can miss an
> accounting cycle, but I don't think that is something to worry too
> much about.
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

applied to tip/sched/rt, thanks guys!

Ingo


\
 
 \ /
  Last update: 2008-11-03 11:31    [W:0.559 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site