Messages in this thread | | | Date | Mon, 3 Nov 2008 10:41:59 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] ftrace: use kretprobe trampoline name to test in output |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> [ > Ingo, > > Can you get this ready for 2.6.28. Without this fix, tracing > breaks the ia64 build. > ] > > When a function is kprobed, the return address is set to the > kprobe_trampoline, or something similar. This caused the output > of the trace to look confusing when the parent seemed to be this > "kprobe_trampoline" function. > > To fix this, Abhishek Sagar added a test of the instruction pointer > of the parent to see if it matched the kprobe_trampoline. If it > did, the output would print a "[unknown/kretprobe'd]" instead. > > Unfortunately, not all archs do this the same way, and the trampoline > function may not be exported, which causes failures in builds. > > This patch will compare the name instead of the pointer to see > if it matches. This prevents us from depending on a function from > being exported, and should work on all archs. The worst that can > happen is that an arch might use a different name and then we > go back to the confusing output. At least the arch will still build. > > Signed-off-by: Steven Rostedt <srostedt@redhat.com> > Tested-by: Abhishek Sagar <sagar.abhishek@gmail.com> > Acked-by: Abhishek Sagar <sagar.abhishek@gmail.com> > --- > kernel/trace/trace.c | 39 +++++++++++++++++++++------------------ > 1 file changed, 21 insertions(+), 18 deletions(-)
applied to tip/tracing/urgent, thanks!
Ingo
| |