lkml.org 
[lkml]   [2008]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sound: struct device - replace bus_id with dev_name(), dev_set_name()
At Sun, 02 Nov 2008 12:19:16 +0100,
I wrote:
>
> At Sun, 02 Nov 2008 03:50:35 +0100,
> Kay Sievers wrote:
> >
> > --- a/sound/isa/ad1848/ad1848.c
> > +++ b/sound/isa/ad1848/ad1848.c
> > @@ -70,15 +70,15 @@ static int __devinit snd_ad1848_match(st
> > return 0;
> >
> > if (port[n] == SNDRV_AUTO_PORT) {
> > - snd_printk(KERN_ERR "%s: please specify port\n", dev->bus_id);
> > + snd_printk(KERN_ERR "%s: please specify port\n", dev_name(dev));
>
> All the changes in sound/isa/* seem to be better fixed by replacement
> with dev_err().
>
> Other changes look good to me.

I dropped sound/isa/* changes from your patch and applied to sound git
tree now.
The sound/isa* parts are replacement with dev_err() and co as well, so
there is no longer dev->bus_id in sound directory.


thanks,

Takashi


\
 
 \ /
  Last update: 2008-11-03 09:09    [from the cache]
©2003-2011 Jasper Spaans