Messages in this thread | | | Date | Sat, 29 Nov 2008 17:50:39 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH][UML] Boot broken due to buffer overrun |
| |
* Pekka Enberg <penberg@cs.helsinki.fi> [2008-11-29 12:21:46]:
> Hi Balbir, > > On Sat, Nov 29, 2008 at 12:08 PM, Balbir Singh > <balbir@linux.vnet.ibm.com> wrote: > > mconsole_init() passed 256 bytes as length in os_create_unix_socket, while > > the sizeof UNIX_PATH_MAX is 108. This patch fixes that problem and avoids > > a big overrun bug reported on UML bootup. > > Maybe mention that ->sun_path in struct sockaddr_un is UNIX_PATH_MAX > long which causes the problem? >
Yes, the changelog can definitely add that to the changelog, I'll resend the patch if Jeff asks for it.
> > Reported-by: Vikas K Managutte <vikki.km@gmail.com> > > Reported-by: Sarvesh Kumar Lal Das <skldas@gmail.com> > > Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> > > Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
Thanks!
-- Balbir
| |