Messages in this thread | | | Date | Fri, 28 Nov 2008 10:05:39 +0000 | From | Al Viro <> | Subject | Re: [PATCH] vfs, seqfile: make mangle_path() global |
| |
On Sun, Nov 23, 2008 at 09:47:37AM +0100, Ingo Molnar wrote: > > * T?r?k Edwin <edwintorok@gmail.com> wrote: > > > fs/seq_file.c | 14 +++++++- > > include/linux/seq_file.h | 1 + > > Note, i've split these bits out into a separate patch - see it > attached below.
ACK, except that I wouldn't use _GPL in the export - it's trivial to reproduce, so we are not protecting anything here. And all that code has been moved verbatim from seq_path(), which is mine *and* exported without _GPL nonsense.
As far as I'm concerned, all these helpers are as general-purpose as atoi() et.al. - library functions damn close to being non-copyrightable due both to triviality and to being absolutely straightforward implementations - tell anybody to implement it and that's what you'll get.
I'm not fond of proprietary modules, to put it mildly, but let's not get completely ridiculous. In this case it's as dumb as schools trying to ban aspirin in the name of War On Some Drugs.
| |